• Registered: 2010-07-19
  • Posts: 5

Topic: Implement support for RHMMF1RW and SVN access

Hi all.

I have known libnfc recently and I am working to include support for my rfid reader which is a Chinese RS232 one and I don't know which chip uses. I had already done some proof of concepts and I don't think it will take me too much time.
The matter is that even if libnfc plans to be a generic open source library for NFC, it's coded thinking in the PN53 chips.

For example, in nfc.c:
// Try to retrieve PN53x chip revision
// We can not use pn53x_transceive() because abtRx[0] gives no status info
if (!pnd->pdc->transceive(pnd->nds,pncmd_get_firmware_version,2,abtFw,&szFwLen))

I have the datasheet of my device and the protocol specification and there's no command to know the firmware so that's not useful for me.
I will also work on doing the code more generic smile

I also wanted to know if I could get write access to the svn. I have already done some trivial changes. For bigger changes of course I wouldn't apply before discussing them.

Regards, Pablo.

Last edited by pablog (2010-07-19 14:19:43)

  • Registered: 2010-07-19
  • Posts: 5

Re: Implement support for RHMMF1RW and SVN access

Some images, does anyone have the same model? I bought it 2 years ago in rfidshop.com.hk and it seems that it's not being sold anymore.
http://lainconscienciadepablo.net/files/rhmmf1rw_5.jpg
http://lainconscienciadepablo.net/files/rhmmf1rw_1.jpg
http://lainconscienciadepablo.net/files/rhmmf1rw_2.jpg
http://lainconscienciadepablo.net/files/rhmmf1rw_3.jpg
http://lainconscienciadepablo.net/files/rhmmf1rw_4.jpg

Last edited by pablog (2010-08-07 14:18:07)

  • rconty
  • Administrator
  • Offline
  • Registered: 2009-04-22
  • Posts: 642

Re: Implement support for RHMMF1RW and SVN access

Hello Pablog,

pablog wrote:

I have known libnfc recently and I am working to include support for my rfid reader which is a Chinese RS232 one and I don't know which chip uses.

Is your device NFC capable ?

pablog wrote:

I had already done some proof of concepts and I don't think it will take me too much time.
The matter is that even if libnfc plans to be a generic open source library for NFC, it's coded thinking in the PN53 chips.

You are right but actually nobody contribute different driver but PN53x

pablog wrote:

I have the datasheet of my device and the protocol specification and there's no command to know the firmware so that's not useful for me.

In fact, some work have to be done to be more generic.

pablog wrote:

I will also work on doing the code more generic smile

Excellent !

pablog wrote:

I also wanted to know if I could get write access to the svn.
I have already done some trivial changes.
For bigger changes of course I wouldn't apply before discussing them.

This is your second post and you have never contribute a patch or similar... I think it could be better to start to send clean and atomic patches (on development site, using issue tracking) which will be integrated by one of actual developers.

Thanks !

Romuald Conty
  • Registered: 2010-07-19
  • Posts: 5

Re: Implement support for RHMMF1RW and SVN access

rconty wrote:

Hello Pablog,

pablog wrote:

I have known libnfc recently and I am working to include support for my rfid reader which is a Chinese RS232 one and I don't know which chip uses.

Is your device NFC capable ?

My device can read/write 13,56MHz tags so it fits the project, right?

rconty wrote:
pablog wrote:

I also wanted to know if I could get write access to the svn.
I have already done some trivial changes.
For bigger changes of course I wouldn't apply before discussing them.

This is your second post and you have never contribute a patch or similar... I think it could be better to start to send clean and atomic patches (on development site, using issue tracking) which will be integrated by one of actual developers.

Thanks !

I will submit some patch in the next days. I was saying that because I like my contributions remain with my name and in svn AFAIK the author recorded is the committer.

Last edited by pablog (2010-07-21 17:09:59)

  • Registered: 2010-07-19
  • Posts: 5

Re: Implement support for RHMMF1RW and SVN access

I have seen some projects in code.google.com that allow themself to be forked, so that you can see all the clones of the project and then the main branch can merge changes from the clones. Could you enable this feature?

  • rconty
  • Administrator
  • Offline
  • Registered: 2009-04-22
  • Posts: 642

Re: Implement support for RHMMF1RW and SVN access

pablog wrote:

Could you enable this feature?

I don't see any options like this. Maybe you are talking about projects which don't use Subversion as VCS but Mercurial ...

Romuald Conty
  • Registered: 2010-07-19
  • Posts: 5

Re: Implement support for RHMMF1RW and SVN access

rconty wrote:
pablog wrote:

Could you enable this feature?

I don't see any options like this. Maybe you are talking about projects which don't use Subversion as VCS but Mercurial ...

You are right