• Registered: 2009-04-23
  • Posts: 9

Topic: [SOLVED] Bugs in svn for Arygon reader

Hi,

I'm working with the serial driver of arygon on the trunk, and have notice that you are modify quite a few thinks in the past days.

As a tester I will point out some stuff you should change:
- uart.c --> uart_xxx are no longer returning bool so in arygon.c you should change the transcieve to put it to <0 instead of !=0
- arygon.c --> the device name, in line 165 is not well copied. In the PCSC devices the name is adquired from the driver but in arygon serial it is never stored in pndd->acDevice. You should set as it was in previous versions to ARYGON_READER_NAME or similar
   ----> line not correct : strncpy(pnd->acName, pndd->acDevice, DEVICE_NAME_LENGTH - 1);
The issue is that in arygon_list_devices you copy it correctly as it is hardcoded ARYGON.

Hope that helps you out. Really good job, but the changes are making me driving mad. The issue is I cannot use the libfreefare with old versions of libnfc wink

Besides that I will in a few day point you something also for libfreefare.

See you

  • rconty
  • Administrator
  • Offline
  • Registered: 2009-04-22
  • Posts: 642

Re: [SOLVED] Bugs in svn for Arygon reader

Hi,
Thanks for report.

You can now follow this bug here: http://code.google.com/p/libnfc/issues/detail?id=105

Romuald Conty